Skip to content

History / Reviews

Revisions

  • Record review for PR 5545

    @cixzhang cixzhang committed Aug 26, 2026
  • Review-5567: record posted request-changes review

    @cixzhang cixzhang committed Aug 26, 2026
  • Review-5567: record Collapsible reveal review

    @cixzhang cixzhang committed Aug 26, 2026
  • Review-5478: record the CLI case-exact resolver review — approve, unposted (self-review block), merged

    @cixzhang cixzhang committed Aug 26, 2026
  • review: record PR 5513

    @cixzhang cixzhang committed Aug 26, 2026
  • Record review of PR 5515

    @cixzhang cixzhang committed Aug 26, 2026
  • Record review #5512

    @cixzhang cixzhang committed Aug 26, 2026
  • Record review of PR 5510

    @cixzhang cixzhang committed Aug 26, 2026
  • Record review for PR 5514

    @cixzhang cixzhang committed Aug 26, 2026
  • Ratify the LayoutHeader owner for PR 3938

    @cixzhang cixzhang committed Aug 26, 2026
  • Review-5508: approve (drafted) — Selector StyleX source-build fix, loop 1.4.0 / audit 1.12

    @cixzhang cixzhang committed Aug 26, 2026
  • Review PR 3938 round 3a — correct the obsolete round-3 criterion Rounds 2a and 3 asked jiunshinn to keep the template's marginTop:12 and marginBottom:-16 and remove only marginInline. That contradicts ruling 4, which says tabsRow must lose ALL its hand-written CSS and that nothing may be a hardcoded amount. Round 3's layout judgement is withdrawn; its unenforced-play block survives. Six arms driven on the real detail-page route: the retained -16 under-docks by 8px at header padding={6}, deleting tabsRow alone leaves the underline 15px off, a TabList-owned block dock moves the ghost -8px, and the zero-API Section seam fails at padding={6} too. LayoutHeader owning the edge holds 5/5 at both paddings. Whether LayoutHeader grows that surface is filed as ruling 12. Also corrects round 2a's '14px ghost lift on deleting tabsRow' — not reproducible; it belonged to that arm's vAlign flip.

    @cixzhang cixzhang committed Aug 26, 2026
  • review: append PR 5543 round 2

    @cixzhang cixzhang committed Aug 26, 2026
  • Review-5454: round 2 at exact head e24ef4c — approve (drafted) All three round-1 blockers verified satisfied. One new note: the heading pin is scoped to the built-in heading, so a custom renderGroupHeader still loses its chevron when scrolled (byte-identical to the pre-fix frame). Three critic passes; the unguarded arm and the at-rest state were driven rather than cited.

    @cixzhang cixzhang committed Aug 26, 2026
  • Review PR 3938 round 3

    @cixzhang cixzhang committed Aug 26, 2026
  • Record PR 5493 exact-head re-review

    @cixzhang cixzhang committed Aug 26, 2026
  • review: append PR 4590 round 2

    @cixzhang cixzhang committed Aug 26, 2026
  • Review-5303: record round 2 — needs human on the date calendar contract Full-lane re-review at head 1ab1381. Reconciles round 1 point by point, records the three-arm visual evidence and the touch-sheet pair, and carries two conditional public variants pending one maintainer decision. Adds the index row.

    @cixzhang cixzhang committed Aug 26, 2026
  • Review-5385 round 3: create below the threshold is fixed; the new queryEntries seam ships public and blocks

    @cixzhang cixzhang committed Aug 26, 2026
  • review: record PR 5557

    @cixzhang cixzhang committed Aug 26, 2026
  • Review-5214 round 6: critic pass moves the verdict to needs human; #5551 is not a human-taken precedent

    @cixzhang cixzhang committed Aug 26, 2026
  • Review-5214 round 6: registration moved to module scope; class established by #5551

    @cixzhang cixzhang committed Aug 26, 2026
  • Reviews: calibrate fast lane on three PRs

    @cixzhang cixzhang committed Aug 26, 2026
  • Review 5454: preserve custom header width and table scaling

    @cixzhang cixzhang committed Aug 26, 2026
  • Review 5538: approve cleared TransferList audit blockers

    @cixzhang cixzhang committed Aug 26, 2026
  • Review 5520: reject promotion of failed visual captures

    @cixzhang cixzhang committed Aug 26, 2026
  • Review 5540: approve scoped preview-theme icons

    @cixzhang cixzhang committed Aug 26, 2026
  • Review 5543: preserve inherited theme overrides before responsive tiers

    @cixzhang cixzhang committed Aug 26, 2026
  • Review 5525: preserve documented theme config and close trust boundary

    @cixzhang cixzhang committed Aug 26, 2026
  • Review 5483: keep Banner layout machinery private

    @cixzhang cixzhang committed Aug 26, 2026