This repository was archived by the owner on Apr 5, 2022. It is now read-only.
Prevent the sidenav icons from looking too much apart when the sidenav is collapsed and the user is using the expanded property#357
Merged
khoberg merged 1 commit intocjdev2:masterfrom Jun 11, 2021
Conversation
Prevents the sidenav icons from looking too much apart when the sidenav is collapsed. This does the task by not adding the .expanded class if the SideNav is collapsed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The expanded property if LinkGroup is useful to always have visible the items of a menu if it only has just a few items, the problem is that if you set expanded to true and the sidebar is collapsed it still shows all the vertical empty space that is used for the menu items.
Solution
Prevents the sidenav icons from looking too much apart when the sidenav is collapsed. This does the task by not adding the .expanded class if the SideNav is collapsed