Conversation
cjolowicz
force-pushed
the
remove-nox-flake8
branch
5 times, most recently
from
587ed17 to
5948ca0
Compare
added 11 commits
May 9, 2020 08:44
cjolowicz
force-pushed
the
remove-nox-flake8
branch
from
5948ca0 to
2ac1b44
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the Nox session for Flake8, which has been superceded by a pre-commit hook. Remove the development dependencies for Flake8 and its extensions from Poetry.
This change drops support for running Flake8 on older Python versions. While we could add pre-commit hooks for older Python versions, the boilerplate in the pre-commit config does not seem worth it. We still have a Nox session for
mypyrunning on all supported Python versions, so hopefully most issues with unsupported syntax will be caught bemypy.See pre-commit/pre-commit#1425
This change also drops the flake8-black extension, which is not installed into the pre-commit environment for Flake8. Black runs in its own pre-commit hook, so having the same check inside the Flake8 hook does not offer added value.