Skip to content

Pin virtualenv to 20.0.21#359

Merged
cjolowicz merged 1 commit intomasterfrom
virtualenv-20.0.21
Jun 6, 2020
Merged

Pin virtualenv to 20.0.21#359
cjolowicz merged 1 commit intomasterfrom
virtualenv-20.0.21

Conversation

@cjolowicz
Copy link
Owner

No description provided.

@cjolowicz cjolowicz added dependencies Dependencies cookiecutter Changes outside of the template directory labels Jun 6, 2020
@cjolowicz cjolowicz added this to the 2020.6.15 milestone Jun 6, 2020
@cjolowicz cjolowicz merged commit 263c017 into master Jun 6, 2020
@cjolowicz cjolowicz deleted the virtualenv-20.0.21 branch June 6, 2020 06:12
@wandering-tales
Copy link

@cjolowicz Was there any reason to pin the virtualenv package in the constraints file?

@cjolowicz
Copy link
Owner Author

cjolowicz commented Mar 16, 2021

@wandering-tales It was pinned to have more deterministic CI, and to isolate CI failures caused by breaking changes to a PR performing the upgrade. In general, we pin all direct dependencies of GA workflows. virtualenv is an indirect dependency via Nox, but it's special: It bundles pip, so our pin for pip does not affect Nox environments (see #324). Also, in the 20.0.* series virtualenv was in a stabilization phase after its rewrite, so it made good sense to use well-known versions. But I think it's still a good idea even now that virtualenv is stable, and even if we pinned the bundled pip using some other means, such as VIRTUALENV_PIP.

Edit: Just to be clear, the pins in the GA workflow constraints are upgraded by Dependabot. The intention is to always use the latest virtualenv, but gate this through a PR with CI checks.

@wandering-tales
Copy link

@cjolowicz Many thanks for your explanation. You did a great job with this project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cookiecutter Changes outside of the template directory dependencies Dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants