strip harmony-style control tokens from local-engine render#26
Merged
Conversation
local models (gpt-oss variants surfaced via Ollama/LMStudio) leak channel markers like `<|channel>thought<channel|>` and stray `<|start|>` / `<|end|>` tokens into the user-facing message. Add a scrubber applied at the four render touch-points in local.ts (single-shot + tools-on, stub + final). display-only: audit.response and recentChatTurns history still see the raw model output for forensics. local engine only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<|channel>thought<channel|>and stray<|start|>/<|end|>/<|message|>/<|return|>tokens into the user-facing Telegram/web reply.scrubLocalControlTokens(text)insrc/local.tsand applied it at all four render touch-points:renderStreamingStub,renderFinal,renderToolLoopStub,renderToolLoopFinal.audit.responseandrecentChatTurnshistory still see the raw model output for forensics. Local engine only — Claude tiers are untouched.Why
Before:
<|channel>thought<channel|>It is 8:44 PM in London.rendered to the user.After:
It is 8:44 PM in London.Three-pass scrubber:
<|name>...<name|>(drops the channel-header content too).<|start|>,<|end|>, etc.) and orphan closers.Test plan
npm run typecheckcleanbun test— 766 pass, 0 fail (added 7 new tests underdescribe("scrubLocalControlTokens", ...)insrc/local.test.ts)audit.response