Conversation
As part of #2140 DataProxy was reenabled, so to keep the old behaviour of showing a Recline data explorer when uploading or linking to a csv/excel we added it to the default view types. The data explorer view plugin no longer requires the DataStore, as it can use DataProxy. Also tweaked the client side error message to reflect if the error came from the DataStore or the DataProxy.
There is no need to implement `IPackageController` on the plugin as default views are handled differently since #1852. Made title translatable on image and web plugins
Better not to mess with low level session caches etc. It is no longer relevant after #1852
As it is already shown on the tab (http://i.imgur.com/IopLCyq.png)
amercader
added a commit
that referenced
this pull request
Feb 4, 2015
As part of #2140 DataProxy was reenabled, so to keep the old behaviour of showing a Recline data explorer when uploading or linking to a csv/excel we added it to the default view types. The data explorer view plugin no longer requires the DataStore, as it can use DataProxy. Also tweaked the client side error message to reflect if the error came from the DataStore or the DataProxy.
amercader
added a commit
that referenced
this pull request
Feb 4, 2015
There is no need to implement `IPackageController` on the plugin as default views are handled differently since #1852. Made title translatable on image and web plugins
amercader
added a commit
that referenced
this pull request
Feb 4, 2015
amercader
added a commit
that referenced
this pull request
Feb 4, 2015
Better not to mess with low level session caches etc. It is no longer relevant after #1852
amercader
added a commit
that referenced
this pull request
Feb 4, 2015
As it is already shown on the tab (http://i.imgur.com/IopLCyq.png)
amercader
added a commit
that referenced
this pull request
Feb 4, 2015
amercader
added a commit
that referenced
this pull request
Feb 4, 2015
Member
Author
|
cheers @joetsoi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various minor internal resource views stuff
IPackageControllerstuff from text and PDF view plugin, views are now automatically created viackan.views.default_viewsconfig option (Better handling of default resource views #1852)gen_new_resourcesfromlib/datapreviewand the toolkitrecline_viewto DEFAULT_RESOURCE_VIEW_TYPES