Skip to content

#9299 Fix duplicated root path in webassets#9300

Merged
smotornyuk merged 3 commits into
masterfrom
9299_fix_duplicated_root_path_in_webassets
Mar 31, 2026
Merged

#9299 Fix duplicated root path in webassets#9300
smotornyuk merged 3 commits into
masterfrom
9299_fix_duplicated_root_path_in_webassets

Conversation

@Zharktas
Copy link
Copy Markdown
Member

@Zharktas Zharktas commented Mar 31, 2026

Fixes #9299, #5615, #7369

Proposed fixes:

root_path gets added in toolkit.py and during rendering in

# Add `site_root` if configured
urls = [url_for_static_or_external(url) for url in bundle.urls()]

This removes it from toolkit.py, as core assets are functioning correctly.
Also updates docs which closes couple related issues.

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

Please [X] all the boxes above that apply

@Zharktas Zharktas marked this pull request as ready for review March 31, 2026 10:45
@smotornyuk smotornyuk merged commit e4ee85a into master Mar 31, 2026
44 of 45 checks passed
@smotornyuk smotornyuk deleted the 9299_fix_duplicated_root_path_in_webassets branch March 31, 2026 18:08
@ckanbot
Copy link
Copy Markdown

ckanbot commented Mar 31, 2026

Successfully created backport PR for dev-v2.11:

@ckanbot
Copy link
Copy Markdown

ckanbot commented Mar 31, 2026

Successfully created backport PR for dev-v2.10:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate root_path on webassets

3 participants