Conversation
Hanssen0
commented
Sep 9, 2025
Hanssen0
commented
- I have read the Contributing Guidelines
* The runtime will invoke the decorator with 2 arguments, but the decorator expects 1. * Decorator function return type '...' is not assignable to type '...'
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @Hanssen0, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request integrates a set of fixes from the releases/fixs branch into the release branch. The changes primarily focus on enhancing the robustness of core functionalities, including critical fixes for Nostr signature verification and a mol.codec decorator, alongside general maintenance updates to development configurations.
Highlights
- Nostr Signature Verification: Fixed an issue with Nostr signature verification in @ckb-ccc/core, including updating the SHA256 import and correcting public key handling.
- ccc.mol.codec Decorator: Resolved issues with the ccc.mol.codec decorator in @ckb-ccc/core, specifically addressing incorrect argument handling and return type assignments.
- Configuration File Renaming: Renamed Vitest configuration files across multiple packages and the root from .ts to .mts.
- TypeScript Compilation Updates: Updated TypeScript compilation options in the playground to target ES2020 and use NodeNext module resolution.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
✅ Deploy Preview for liveccc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for appccc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for docsccc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Code Review
This pull request introduces several fixes and configuration updates. Key changes include a critical correction to the Nostr signature verification logic in @ckb-ccc/core to ensure the public key is properly included when hashing the event, which resolves a potential security and correctness issue. Another fix addresses a bug in the ccc.mol.codec decorator, making it compatible with the arguments passed by the TypeScript runtime and correcting associated type definitions. The remaining changes involve updating TypeScript compiler options for the playground and renaming Vitest configuration files to align with ES module standards. The fixes appear correct and well-implemented. Overall, this is a good set of changes that improves the robustness and correctness of the codebase.
✅ Deploy Preview for apiccc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
1 participant
