feat(node): support specify the path to a CKB binary#317
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for specifying a custom path to a CKB binary, allowing developers to use locally compiled CKB binaries instead of relying on pre-installed versions.
Key Changes:
- Added
binaryPathparameter toNodePropinterface and related functions to accept custom binary paths - Added
--binary-pathCLI option to thenodecommand - Updated documentation with usage examples for the new feature
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/cmd/node.ts | Added binaryPath parameter to NodeProp interface, startNode, and nodeDevnet functions; implemented logic to use custom binary path when provided |
| src/cli.ts | Added --binary-path CLI option to the node command with description indicating it ignores version and network parameters |
| README.md | Added documentation section explaining the new --binary-path option with usage examples; updated table of contents formatting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RetricSu
force-pushed
the
feat/node-bin-path-option
branch
from
96144c0 to
cb29ad6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.