Skip to content

Fix not starting CI and e2e tests#96

Merged
f1ames merged 4 commits intomasterfrom
t/86
Mar 23, 2020
Merged

Fix not starting CI and e2e tests#96
f1ames merged 4 commits intomasterfrom
t/86

Conversation

@Dumluregn
Copy link
Collaborator

@Dumluregn Dumluregn commented Mar 19, 2020

What I did here was basically:

  1. Bump Protractor dependency;
  2. Then some install scripts in travis.yml became unnecessary so I deleted them;
  3. This was not enough as Travis still kept wrong cache, so I cleared it and disabled caching in the future (if we observe dramatic loss of Travis performance we can restore this setting, but for now it turned to be more problematic than beneficial).
  4. After all I also updated two invalid Travis config options.

Now CI should work (but it doesn't mean it will be green...). Also thanks to webdriver-manager included in Protractor update, e2e tests should start working (also here it doesn't mean they will pass right away).

Closes #86.
Closes #60.

@Dumluregn Dumluregn changed the title Fix CI not running builds Fix not starting CI and e2e tests Mar 19, 2020
@f1ames f1ames self-requested a review March 23, 2020 15:54
@f1ames f1ames self-assigned this Mar 23, 2020
@f1ames
Copy link
Contributor

f1ames commented Mar 23, 2020

Rebased onto latest master.

Copy link
Contributor

@f1ames f1ames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now CI should work (but it doesn't mean it will be green...).

Halfway there then 👍 Good job 🆗

@f1ames f1ames merged commit eb16e53 into master Mar 23, 2020
@CKEditorBot CKEditorBot deleted the t/86 branch March 23, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Travis build produces error e2e tests are not starting

3 participants