Conversation
Contributor
|
Rebased onto latest |
f1ames
approved these changes
Mar 23, 2020
Contributor
f1ames
left a comment
There was a problem hiding this comment.
Now CI should work (but it doesn't mean it will be green...).
Halfway there then 👍 Good job 🆗
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did here was basically:
Protractordependency;travis.ymlbecame unnecessary so I deleted them;Travisconfig options.Now CI should work (but it doesn't mean it will be green...). Also thanks to
webdriver-managerincluded inProtractorupdate, e2e tests should start working (also here it doesn't mean they will pass right away).Closes #86.
Closes #60.