Fixed emoji filtering and improved the filtering performance.#17864
Merged
Fixed emoji filtering and improved the filtering performance.#17864
Conversation
Contributor
|
Please change target branch to |
pomek
reviewed
Feb 3, 2025
Member
pomek
left a comment
pomek
left a comment
There was a problem hiding this comment.
I left a few comments. Other than that, WFM when it comes to unsupported symbols.
Before:
After:
Unfortunately, even if the following emoji is supported, the mechanism filters it out.
Symbols:
- https://emojipedia.org/family-adult-adult-child-child
- https://emojipedia.org/family-adult-adult-child
- https://emojipedia.org/family-adult-child
- https://emojipedia.org/family-adult-child-child
Before:
After:
pomek
reviewed
Feb 3, 2025
psmyrek
reviewed
Feb 3, 2025
Contributor
psmyrek
left a comment
psmyrek
left a comment
There was a problem hiding this comment.
It filters out too much now 🤔
Before, I found at least two emojis that were correctly rendered in my OS:
On this branch, at least these two emojis are unnecessarily filtered out:
This comment was marked as resolved.
This comment was marked as resolved.
pomek
approved these changes
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Internal: Fixed emoji filtering and improved the filtering performance. Closes #17834.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.