Improve detecting which items should be reconverted when using skip-level lists#20104
Merged
mmotyczynska merged 5 commits intoApr 28, 2026
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…nto cc/9765-changing-list-start-after-skip-level-not-visible
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0834c16. Configure here.
mmotyczynska
requested review from
Mati365,
gorzelinski,
niegowski and
pszczesniak
niegowski
reviewed
Apr 28, 2026
| // lower-indent ancestor (mirroring the downcast's fallback). Remember that item here | ||
| // so later we can compare the wrapper against the current model and tell whether it's | ||
| // still up to date. | ||
| for ( let i = itemIndent - 1; i >= 0; i-- ) { |
Contributor
There was a problem hiding this comment.
Maybe we could extract this loop to a local helper function? Sth like fillStackForIntermediates or sth like this.
Comment on lines
+290
to
+293
| ...Object.fromEntries( | ||
| Array.from( referenceItem.getAttributes() ) | ||
| .filter( ( [ key ] ) => attributeNames.includes( key ) ) | ||
| ), |
Contributor
There was a problem hiding this comment.
This part is exactly the same as L256-259, so maybe a tiny local helper would make this code a bit more readable?
mmotyczynska
deleted the
cc/9765-changing-list-start-after-skip-level-not-visible
branch
niegowski
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Summary
A brief summary of what this PR changes.
📌 Related issues
💡 Additional information
Optional: Notes on decisions, edge cases, or anything helpful for reviewers.
🧾 Checklists
Use the following checklists to ensure important areas were not overlooked.
This does not apply to feature-branch merges.
If an item is not relevant to this type of change, simply leave it unchecked.
Author checklist
Reviewer checklist
t()(if any).