Merge #master to #release for testing phase#20123
Conversation
…e-in-code-blocks Disabled mention, emoji and slash commands in code blocks.
…k-followup Fixed an edge case where mention is sometimes still displayed in a code block.
…bjects during content insertion, which could crash the editor when a permissive addAttributeCheck is used.
* Rephrased LTS error code. * Fixed wording. Co-authored-by: Witek Socha <w.socha@cksource.com>
…aste from office. (#20105)
* Add code snippets to editor types guide. * Wrap captions in the snippet footer. * Polish some paragraphs. * Fix console logs. * Fix typo. * Add missing imports. * Update the date. --------- Co-authored-by: Mateusz Gorzeliński <mateusz.gorzelinski@gmail.com>
Update dependencies.
…r-v2 Fix inconsistent marker boundary order v2
…ules/require-explicit-data-context linter rules.
Added docs for no-literal-dollar-root and require-explicit-data-context linter rules.
Co-authored-by: Mateusz Gorzeliński <mateusz.gorzelinski@gmail.com>
Added the `ViewDocument#getRoots()` method and editor root description configuration property
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7b4bc3e. Configure here.
|
|
||
| if ( roots[ rootName ].initialData === undefined ) { | ||
| roots[ rootName ].initialData = getDataFromElement( sourceElements[ rootName ] ); | ||
| roots[ rootName ].initialData = getDataFromElement( roots[ rootName ].element ); |
There was a problem hiding this comment.
Removed parameter still referenced in code example
High Severity
The sourceElements parameter was removed from the constructor( config ) signature, but the constructor body still references sourceElements in three places: Object.keys( sourceElements ) on lines iterating root names, and when constructing MultirootEditorUIView. The getDataFromElement call was correctly updated to roots[ rootName ].element, but the loop variables and the UI view instantiation were not. Anyone copying this tutorial code will get a ReferenceError at runtime. These references likely need to use roots instead.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 7b4bc3e. Configure here.
18 participants
🚀 Summary
Merge
#masterto#releasefor testing phase.