Skip to content

Fix AI tabs transitionend listener not being removed after leaving fullscreen.#20130

Merged
l-lejman merged 2 commits into
releasefrom
ck/20129
May 7, 2026
Merged

Fix AI tabs transitionend listener not being removed after leaving fullscreen.#20130
l-lejman merged 2 commits into
releasefrom
ck/20129

Conversation

@l-lejman
Copy link
Copy Markdown
Contributor

@l-lejman l-lejman commented May 7, 2026

🚀 Summary

Adding and removing event listeners used different function references, so the listeners were not removed properly. We need to use a wrapper function or store the .bind(this) reference to properly remove the listeners.

The issue can be reproduced by simply opening and closing fullscreen mode, then using maximize in AI Chat.


📌 Related issues


💡 Additional information

Optional: Notes on decisions, edge cases, or anything helpful for reviewers.


🧾 Checklists

Use the following checklists to ensure important areas were not overlooked.
This does not apply to feature-branch merges.
If an item is not relevant to this type of change, simply leave it unchecked.

Author checklist

  • Is the changelog entry intentionally omitted?
  • Is the change backward-compatible?
  • Have you considered the impact on different editor setups and core interactions? (e.g., classic/inline/multi-root/many editors, typing, selection, paste, tables, lists, images, collaboration, pagination)
  • Has the change been manually verified in the relevant setups?
  • Does this change affect any of the above?
  • Is performance impacted?
  • Is accessibility affected?
  • Have tests been added that fail without this change (against regression)?
  • Have the API documentation, guides, feature digest, and related feature sections been updated where needed?
  • Have metadata files (ckeditor5-metadata.json) been updated if needed?
  • Are there any changes the team should be informed about (e.g. architectural, difficult to revert in future versions or having impact on other features)?
  • Were these changes documented (in Logbook)?

Reviewer checklist

  • PR description explains the changes and the chosen approach (especially when performance, API, or UX is affected).
  • The changelog entry is clear, user‑ or integrator-facing, and it describes any breaking changes.
  • All new external dependencies have been approved and mentioned in LICENSE.md (if any).
  • All human-readable, translateable strings in this PR been introduced using t() (if any).
  • I manually verified the change (e.g., in manual tests or documentation).
  • The target branch is correct.

@l-lejman l-lejman changed the base branch from master to release May 7, 2026 13:13
@l-lejman l-lejman changed the title Ck/20129 Fix AI tabs transitionend listener not removed after leaving fullscreen May 7, 2026
@l-lejman l-lejman changed the title Fix AI tabs transitionend listener not removed after leaving fullscreen Fix AI tabs transitionend listener not being removed after leaving fullscreen. May 7, 2026
@l-lejman l-lejman merged commit b7b4700 into release May 7, 2026
11 checks passed
@l-lejman l-lejman deleted the ck/20129 branch May 7, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fullscreen causes AI resize to throw console errors

2 participants