Skip to content

Fix missing This link has no URL label on links with an empty href.#20150

Merged
Mati365 merged 3 commits into
masterfrom
ck/20136
May 14, 2026
Merged

Fix missing This link has no URL label on links with an empty href.#20150
Mati365 merged 3 commits into
masterfrom
ck/20136

Conversation

@Mati365
Copy link
Copy Markdown
Member

@Mati365 Mati365 commented May 14, 2026

🚀 Summary

Fix missing This link has no URL label on links with an empty href.


📌 Related issues


🧾 Checklists

Use the following checklists to ensure important areas were not overlooked.
This does not apply to feature-branch merges.
If an item is not relevant to this type of change, simply leave it unchecked.

Author checklist

  • Is the changelog entry intentionally omitted?
  • Is the change backward-compatible?
  • Have you considered the impact on different editor setups and core interactions? (e.g., classic/inline/multi-root/many editors, typing, selection, paste, tables, lists, images, collaboration, pagination)
  • Has the change been manually verified in the relevant setups?
  • Does this change affect any of the above?
  • Is performance impacted?
  • Is accessibility affected?
  • Have tests been added that fail without this change (against regression)?
  • Have the API documentation, guides, feature digest, and related feature sections been updated where needed?
  • Have metadata files (ckeditor5-metadata.json) been updated if needed?
  • Are there any changes the team should be informed about (e.g. architectural, difficult to revert in future versions or having impact on other features)?
  • Were these changes documented (in Logbook)?

Reviewer checklist

  • PR description explains the changes and the chosen approach (especially when performance, API, or UX is affected).
  • The changelog entry is clear, user‑ or integrator-facing, and it describes any breaking changes.
  • All new external dependencies have been approved and mentioned in LICENSE.md (if any).
  • All human-readable, translateable strings in this PR been introduced using t() (if any).
  • I manually verified the change (e.g., in manual tests or documentation).
  • The target branch is correct.

@Mati365 Mati365 requested a review from pszczesniak May 14, 2026 12:24
Copy link
Copy Markdown
Contributor

@pszczesniak pszczesniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should also remove the tooltip completely when there is no url.

Image

Other than that 👍

@Mati365 Mati365 requested a review from pszczesniak May 14, 2026 12:50
@Mati365 Mati365 merged commit 4852231 into master May 14, 2026
11 checks passed
@Mati365 Mati365 deleted the ck/20136 branch May 14, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Link preview button shows empty label when the selected link has no href (regression vs v41)

2 participants