Conversation
|
After changes it should look like this:
|
mmotyczynska
left a comment
mmotyczynska
left a comment
There was a problem hiding this comment.
It looks better, but I'd suggest a few more improvements.
The editor content should have a different background. Compare the two:
Original
GitHub Writer:
The background should be the same colour as the Write tab. If we change this, it would be better for the dropdowns, which don't look good now because everything has the same background colour:
Maybe we should also consider adding a border/outline to the dropdown so the user can see exactly where it ends.
We could also consider bumping the CKEditor version.
pszczesniak
left a comment
pszczesniak
left a comment
There was a problem hiding this comment.
As far as i can see - CSS variables in GitHub were changed - for example:
from --color-border-default into --borderColor-default
Maybe would be good to just update those variables names and potentially this could fix the problem, WDYT?
pszczesniak
left a comment
pszczesniak
left a comment
There was a problem hiding this comment.
I've tested it on latest Chrome and Firefox with dark/light/auto theme and all looks like it should 👍
One thing we could update also - background in table in an even row:
This variable can be changed into: --bgColor-muted.
|
And this issue: #482 will be also closed by this PR 🎉 |
3 participants
Updates css styles for fixing broken appearance. Closes: #480