Adjust ActivityPub bookmark representation to match Betula#219
Open
bouncepaw wants to merge 1 commit into
Open
Adjust ActivityPub bookmark representation to match Betula#219bouncepaw wants to merge 1 commit into
bouncepaw wants to merge 1 commit into
Conversation
bouncepaw
commented
Jul 1, 2026
|
|
||
| const noteMessage = { | ||
| '@context': 'https://www.w3.org/ns/activitystreams', | ||
| '@context': ['https://www.w3.org/ns/activitystreams', { Hashtag: 'https://www.w3.org/ns/activitystreams#Hashtag' }], |
Author
There was a problem hiding this comment.
For formal correctness. Practical implementations often ignore JSON-LD contexts, but some of them don't.
bouncepaw
commented
Jul 1, 2026
| for (const follower of followers) { | ||
| const inbox = `${follower}/inbox`; | ||
| console.log(`Sending to ${follower}...`); | ||
| const inbox = await getInboxFromActorProfile(follower); |
Author
There was a problem hiding this comment.
You took a shortcut here, which made sense, but the old logic failed for some servers such as Betula. Some form of caching would make sense, but I didn't find a db table with remote actors.
bouncepaw
commented
Jul 1, 2026
| function getSignatureHeader(signature, signatureKeys) { | ||
| return [ | ||
| `keyId="https://${domain}/u/${account}"`, | ||
| `keyId="https://${domain}/u/${account}#main-key"`, |
Author
There was a problem hiding this comment.
Did it work before? It shouldn't have.
Owner
|
hey! Just FYI I'm traveling for the US holiday this week but this looks interesting and I'm putting it on my todo list when I get back next week. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
This pull request changes the way bookmarks are represented over ActivityPub so they can be displayed by Betula. The same format is also used by Ties and Omnom. I'm also writing a FEP for this format.
I also fixed a bug with public keys.
This is what a Postmarks bookmark looks like in Betula:
And in Mastodon: