muqss: fix lockdep-enabled build#2
Merged
ckolivas merged 1 commit intockolivas:4.12-ckfrom Aug 17, 2017
sergey-senozhatsky:4.12-ck
Merged
muqss: fix lockdep-enabled build#2ckolivas merged 1 commit intockolivas:4.12-ckfrom sergey-senozhatsky:4.12-ck
ckolivas merged 1 commit intockolivas:4.12-ckfrom
sergey-senozhatsky:4.12-ck
Conversation
Fix by passing rq->lock pointer to lockdep_is_held():
In file included from ./arch/x86/include/asm/bug.h:81:0,
from ./include/linux/bug.h:4,
from ./include/linux/thread_info.h:11,
from ./arch/x86/include/asm/preempt.h:6,
from ./include/linux/preempt.h:80,
from ./include/linux/spinlock.h:50,
from ./include/linux/rcupdate.h:38,
from ./include/linux/rculist.h:10,
from ./include/linux/pid.h:4,
from ./include/linux/sched.h:13,
from kernel/sched/MuQSS.c:33:
kernel/sched/MuQSS.c: In function ‘set_task_cpu’:
./include/linux/lockdep.h:351:52: error: invalid type argument of ‘->’ (have ‘raw_spinlock_t {aka struct raw_spinlock}’)
#define lockdep_is_held(lock) lock_is_held(&(lock)->dep_map)
^~
./include/asm-generic/bug.h:65:25: note: in definition of macro ‘WARN_ON_ONCE’
int __ret_warn_on = !!(condition); \
^~~~~~~~~
kernel/sched/MuQSS.c:1275:11: note: in expansion of macro ‘lockdep_is_held’
lockdep_is_held(rq->lock)));
^~~~~~~~~~~~~~~
Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix by passing rq->lock pointer to lockdep_is_held():
In file included from ./arch/x86/include/asm/bug.h:81:0,
from ./include/linux/bug.h:4,
from ./include/linux/thread_info.h:11,
from ./arch/x86/include/asm/preempt.h:6,
from ./include/linux/preempt.h:80,
from ./include/linux/spinlock.h:50,
from ./include/linux/rcupdate.h:38,
from ./include/linux/rculist.h:10,
from ./include/linux/pid.h:4,
from ./include/linux/sched.h:13,
from kernel/sched/MuQSS.c:33:
kernel/sched/MuQSS.c: In function ‘set_task_cpu’:
./include/linux/lockdep.h:351:52: error: invalid type argument of ‘->’ (have ‘raw_spinlock_t {aka struct raw_spinlock}’)
#define lockdep_is_held(lock) lock_is_held(&(lock)->dep_map)
^~
./include/asm-generic/bug.h:65:25: note: in definition of macro ‘WARN_ON_ONCE’
int __ret_warn_on = !!(condition);
^~~~~~~~~
kernel/sched/MuQSS.c:1275:11: note: in expansion of macro ‘lockdep_is_held’
lockdep_is_held(rq->lock)));
^~~~~~~~~~~~~~~
Signed-off-by: Sergey Senozhatsky sergey.senozhatsky@gmail.com