feat(taxonomy): add political domain with donation/campaign categories#38
Merged
Conversation
Adds 'political' as a canonical domain in HouseholdTaxonomy with four subject-level categories (advocacy, campaign, donation, voter) and domain aliases for politics/election/elections. Form is carried by the existing 'receipts' doctype, so campaign-donation receipts (ActBlue, WinRed) now resolve as political/donation/receipts instead of failing taxonomy validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Campaign-donation receipts (ActBlue, WinRed) currently fail taxonomy validation because no canonical domain accepts them. This change adds
politicalas a canonical domain so those receipts resolve aspolitical/donation/receipts/...instead of falling through to fallback or strict-mode failure.What
Adds to
HouseholdTaxonomy:politicalpolitics,election,electionspolitical:advocacy,campaign,donation,voterForm (receipt/invoice/agreement/etc.) is still carried by the existing
receiptsdoctype — no new doctype required.Scope
src/drover/taxonomy/household.py(+10 lines)