Skip to content

fix: store state (and event-listener) on element #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexandremoore merged 1 commit into from
Oct 9, 2018
Merged

fix: store state (and event-listener) on element #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 34 additions & 19 deletions src/directive.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,16 +34,42 @@ export function setDefaults(options) {
defaults = _extends({}, defaults, options);
}

function setup(el, clampValue) {
tearDown(el);

const resizeListener = () => {
clampElement(el, clampValue);
};

el.__VueClampy = {
clampValue,
resizeListener
};

// Re-clamp on element resize
// resizeDetector.listenTo(el, () => {
// clampElement(el, clampValue);
// });

// Also re-clamp on window resize
window.addEventListener('resize', resizeListener);

clampElement(el, clampValue);
}

function tearDown(el) {
if (!el || !el.__VueClampy) return;
// Remove all listeners
// resizeDetector.removeAllListeners(el);
window.removeEventListener('resize', el.__VueClampy.resizeListener);
}

function setInitialContent(el) {
if (el.clampInitialContent === undefined) {
el.clampInitialContent = el.innerHTML.trim();
}
}

function clampOnResize(el, clampValue) {
clampElement(el, clampValue);
}

function clampElement(el, clamp) {
// We use element-resize-detector to trigger the ellipsis.
// Element-resize-detector adds an inner div to monitor
Expand Down Expand Up @@ -77,27 +103,16 @@ function clampElement(el, clamp) {
export default {
inserted(el, binding, vnode) {
clampValue = binding.value;
// Re-clamp on element resize
// resizeDetector.listenTo(el, () => {
// clampElement(el, clampValue);
// });

// Also re-clamp on window resize
window.addEventListener('resize', clampOnResize);

clampElement(el, clampValue);
setup(el, clampValue);
},

update(el, binding, vnode) {
clampValue = binding.value;
clampElement(el, clampValue);
setup(el, clampValue);
},

unbind(el, binding, vnode) {
clampValue = binding.value;

// Remove all listeners
// resizeDetector.removeAllListeners(el);
window.removeEventListener('resize', clampOnResize);
tearDown(el);
delete el.__VueClampy;
}
};
53 changes: 34 additions & 19 deletions vue-clampy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,16 +321,42 @@ function setDefaults(options) {
defaults = _extends({}, defaults, options);
}

function setup(el, clampValue) {
tearDown(el);

var resizeListener = function resizeListener() {
clampElement(el, clampValue);
};

el.__VueClampy = {
clampValue: clampValue,
resizeListener: resizeListener
};

// Re-clamp on element resize
// resizeDetector.listenTo(el, () => {
// clampElement(el, clampValue);
// });

// Also re-clamp on window resize
window.addEventListener('resize', resizeListener);

clampElement(el, clampValue);
}

function tearDown(el) {
if (!el || !el.__VueClampy) return;
// Remove all listeners
// resizeDetector.removeAllListeners(el);
window.removeEventListener('resize', el.__VueClampy.resizeListener);
}

function setInitialContent(el) {
if (el.clampInitialContent === undefined) {
el.clampInitialContent = el.innerHTML.trim();
}
}

function clampOnResize(el, clampValue) {
clampElement(el, clampValue);
}

function clampElement(el, clamp) {
// We use element-resize-detector to trigger the ellipsis.
// Element-resize-detector adds an inner div to monitor
Expand Down Expand Up @@ -364,26 +390,15 @@ function clampElement(el, clamp) {
var VueClampy$1 = {
inserted: function inserted(el, binding, vnode) {
clampValue = binding.value;
// Re-clamp on element resize
// resizeDetector.listenTo(el, () => {
// clampElement(el, clampValue);
// });

// Also re-clamp on window resize
window.addEventListener('resize', clampOnResize);

clampElement(el, clampValue);
setup(el, clampValue);
},
update: function update(el, binding, vnode) {
clampValue = binding.value;
clampElement(el, clampValue);
setup(el, clampValue);
},
unbind: function unbind(el, binding, vnode) {
clampValue = binding.value;

// Remove all listeners
// resizeDetector.removeAllListeners(el);
window.removeEventListener('resize', clampOnResize);
tearDown(el);
delete el.__VueClampy;
}
};

Expand Down