Conversation
VDH image extractions now return source timepoints
brought back "source" information as part of workflowId
fixed docs.py for building old versions with setup.py
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #389 +/- ##
==========================================
+ Coverage 73.62% 74.78% +1.15%
==========================================
Files 27 27
Lines 3204 3228 +24
==========================================
+ Hits 2359 2414 +55
+ Misses 845 814 -31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Improves image-extraction API in
video_document_helperfor TP source tracking, restores the source-composition prefix in workflow identifiers, and fixes the versioned-docs publishing pipeline.Additions
extract_images_by_count_with_sourcesandextract_images_by_mode_with_sources: new public functions inmmif.utils.video_document_helperthat return per-image source IDs (or sampled timepoints in ms when a fallback path is used), so downstream apps can anchor each extracted image to a specific point in the source media (VDH image extractions now return source timepoints #385,vdh.extract_frames_by_modeshould also return "source" information #384).Changes
mmif.utils.video_document_helper: renamedextract_timepoints_as_images-->extract_images_from_timepoints,extract_target_frames-->extract_images_by_count_with_sources(alongside new bareextract_images_by_count), andextract_frames_by_mode-->extract_images_by_mode.mmif.utils.workflow_helper.generate_workflow_identifier: now prefixes asource_compositionsegment (TextDocument-1-VideoDocument-1/...) describing the top-level document mix in the input MMIF (brought back "source" information as part of workflowId #386).build-tools/docs.py: versioned-docs build now works against pyproject-only tags, restoring docs publishing in the release workflow (fixed docs.py for building old versions with setup.py #388,docs.pyis broken on CI #387).Note
mmif describe(and the underlyingmmif.utils.workflow_helper) is still experimental and subject to change in future releases without notice. Backward compatibility is not guaranteed.source_compositionprefix ingenerate_workflow_identifier()changes the format of returned identifiers. Downstream tools parsing the identifier path (e.g. for storage-directory routing) may need to account for the extra leading segment.