Remove database queries from nav template#174
Merged
Conversation
This allows for `import attrs`.
There is now no access from this template. Adding this tag prevents regression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We shouldn't be making queries in templates, but unfortunately, that happens a lot in this project.
This removes the database queries from the nav template, and moves them into the nav templatetag code. I'm not in love with the code that's come out of this, but it's a step in the right direction.
As a bonus, we've shaved a few queries out of what is required when rendering the page.
I've shamelessly added my new library
django-sans-db, and have set it up to prevent regressions in this template.