Merged
Conversation
meshy
changed the title
Before now, we've been using a postgres database to store the data in production. It's not worth the maintenance cost. This changes the start-up script we use in production to create and populate an SQLite file before we start the server process. We probably don't need to take the step of removing the sqlite file, but I'm not sure if it might already exist from previous builds in prod.
meshy
force-pushed
the
switch-to-in-memory-database
branch
from
230e4d9 to
68bee52
Compare
ghickman
approved these changes
Jul 15, 2023
Contributor
ghickman
left a comment
ghickman
left a comment
There was a problem hiding this comment.
Do you want to drop psycopg2 from the requirements too? or are we keeping that for local dev?
I'll be nice to stop the need for a seperate db service in production!
Contributor
Author
|
That's probably a good idea, but I'm going to leave that for another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before now, we've been using a postgres database to store the data in production. It's not worth the maintenance cost.
This changes the start-up script we use in production to create and populate an SQLite file before we start the server process.
We probably don't need to take the step of removing the sqlite file, but I'm not sure if it might already exist from previous builds in prod.