Skip to content

Don't count protocols in test coverage #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meshy merged 1 commit into from
May 19, 2024
Merged

Don't count protocols in test coverage #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cbv/importer/importers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
)


class CodeImporter(Protocol):
class CodeImporter(Protocol): # nocoverage: protocol
def generate_code_data(self) -> Iterator[CodeElement]: ...


Expand Down
4 changes: 4 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ dynamic_context = "test_function"
[tool.coverage.report]
show_missing = true
skip_covered = true
exclude_lines = [
# Protocol classes are abstract, and don't need coverage.
"nocoverage: protocol",
]

[tool.coverage.html]
show_contexts = true
Expand Down
2 changes: 1 addition & 1 deletion tests/test_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
from .factories import KlassFactory, ProjectVersionFactory


class AssertNumQueriesFixture(Protocol):
class AssertNumQueriesFixture(Protocol): # nocoverage: protocol
def __call__(self, num: int, exact: bool = True) -> CaptureQueriesContext: ...


Expand Down