fix: preserve SVG namespace in clone feedback placeholder sync#1968
Merged
fix: preserve SVG namespace in clone feedback placeholder sync#1968
Conversation
🦋 Changeset detectedLatest commit: 267c97c The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Replace innerHTML with cloneNode + replaceChildren in the element mutation observer. innerHTML serializes/parses as HTML, stripping SVG namespace info from inline SVG children. This caused placeholders to measure with wrong dimensions, misaligning the drop animation. Closes #1962 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
clauderic
force-pushed
the
claude/keen-kepler
branch
from
a7f9a81 to
267c97c
Compare
@dnd-kit/abstract
@dnd-kit/collision
@dnd-kit/dom
@dnd-kit/geometry
@dnd-kit/helpers
@dnd-kit/react
@dnd-kit/solid
@dnd-kit/state
@dnd-kit/svelte
@dnd-kit/vue
commit: |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
innerHTMLwithreplaceChildren(...element.cloneNode(true).childNodes)in the element mutation observer for clone feedback placeholdersinnerHTMLserializes/parses as HTML, stripping SVG namespace info from inline<svg>children (e.g. Lucide icons), causing the placeholder to measure with wrong dimensions and the drop animation to land at the wrong positionTest plan
feedback="clone"that contains inline SVG children (e.g. a badge with a Lucide icon next to text)Closes #1962
🤖 Generated with Claude Code