[GPU][AMD] Fix lldb hipcc tests to link using libstdc++ #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the test Makefile.rules to force linking with libstdc++ when building with hipcc. An upstream [change](llvm#164462) modified the test link commands to add -nostdlib++ to avoid linking both the internal llvm c++ library and the external system c++ standard library. This was causing linking failures when building with hipcc because it expects to use the system libstdc++ library.
clayborg
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the test Makefile.rules to force linking with libstdc++ when building with hipcc.
An upstream change modified the test link commands to add -nostdlib++ to avoid linking both the internal llvm c++ library and the external system c++ standard library. This was causing linking failures when building with hipcc because it expects to use the system libstdc++ library.