AWS: Added multi-account scanning feature#110
Merged
Merged
Conversation
sureshcsdp
temporarily deployed
to
cleancloud-test
GitHub Actions
Inactive
sureshcsdp
temporarily deployed
to
cleancloud-test
GitHub Actions
Inactive
sureshcsdp
temporarily deployed
to
cleancloud-test
GitHub Actions
Inactive
sureshcsdp
temporarily deployed
to
cleancloud-test
GitHub Actions
Inactive
sureshcsdp
temporarily deployed
to
cleancloud-test
GitHub Actions
Inactive
sureshcsdp
temporarily deployed
to
cleancloud-test
GitHub Actions
Inactive
sureshcsdp
temporarily deployed
to
cleancloud-test
GitHub Actions
Inactive
| profile: Optional[str] = None, | ||
| region: Optional[str] = None, | ||
| ) -> None: | ||
| region = region or "us-east-1" |
Collaborator
There was a problem hiding this comment.
why is this defaulting to us-east-1?
Collaborator
Author
There was a problem hiding this comment.
its for STS just added a comment
| Before running a full scan, validate that CleanCloud can reach all target accounts: | ||
|
|
||
| ```bash | ||
| cleancloud doctor --provider aws --multi-account accounts.yaml |
Collaborator
There was a problem hiding this comment.
where should the accounts.yaml live in the CI/CD env? perhaps users can keep/commit the file in their repos ?
Collaborator
Author
There was a problem hiding this comment.
it can be anywhere, preferably in user's repos, but have updated the docs around it
javvaji-devops
previously approved these changes
Mar 20, 2026
sureshcsdp
temporarily deployed
to
cleancloud-test
GitHub Actions
Inactive
sureshcsdp
temporarily deployed
to
cleancloud-test
GitHub Actions
Inactive
sureshcsdp
temporarily deployed
to
cleancloud-test
GitHub Actions
Inactive
sureshcsdp
temporarily deployed
to
cleancloud-test
GitHub Actions
Inactive
sureshcsdp
temporarily deployed
to
cleancloud-test
GitHub Actions
Inactive
sureshcsdp
temporarily deployed
to
cleancloud-test
GitHub Actions
Inactive
sureshcsdp
temporarily deployed
to
cleancloud-test
GitHub Actions
Inactive
sureshcsdp
temporarily deployed
to
cleancloud-test
GitHub Actions
Inactive
sureshcsdp
temporarily deployed
to
cleancloud-test
GitHub Actions
Inactive
sureshcsdp
temporarily deployed
to
cleancloud-test
GitHub Actions
Inactive
sureshcsdp
temporarily deployed
to
cleancloud-test
GitHub Actions
Inactive
sureshcsdp
temporarily deployed
to
cleancloud-test
GitHub Actions
Inactive
sureshcsdp
temporarily deployed
to
cleancloud-test
GitHub Actions
Inactive
sureshcsdp
temporarily deployed
to
cleancloud-test
GitHub Actions
Inactive
javvaji-devops
approved these changes
Mar 20, 2026
Collaborator
|
LGTM 👍 |
Collaborator
|
I have merged it for you @sureshcsdp :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.