Merged
Conversation
sureshcsdp
temporarily deployed
to
cleancloud-test
GitHub Actions
Inactive
sureshcsdp
temporarily deployed
to
cleancloud-test
GitHub Actions
Inactive
sureshcsdp
temporarily deployed
to
cleancloud-test
GitHub Actions
Inactive
sureshcsdp
temporarily deployed
to
cleancloud-test
GitHub Actions
Inactive
sureshcsdp
temporarily deployed
to
cleancloud-test
GitHub Actions
Inactive
| tags = instance.get("TagList", []) | ||
| tag_keys_lower = {t["Key"].lower() for t in tags} | ||
| if "keep" in tag_keys_lower or "do-not-delete" in tag_keys_lower: | ||
| continue |
Collaborator
There was a problem hiding this comment.
we did you remove this ? intensional ?
Collaborator
Author
There was a problem hiding this comment.
we dont need this as --ignore-flag command line param feature already suports this
| connections = get_metric(DatabaseConnections, period=idle_threshold_days) | ||
| if connections == 0: | ||
| confidence = "HIGH" | ||
| risk = "HIGH" |
Collaborator
Author
There was a problem hiding this comment.
we dont need this as --ignore-flag command line param feature already suports this
| "ReadReplicaSourceDBInstanceIdentifier": None, | ||
| "DBClusterIdentifier": None, | ||
| "TagList": [{"Key": "Keep", "Value": "true"}], | ||
| }, |
| from cleancloud.core.risk import RiskLevel | ||
|
|
||
|
|
||
| def find_idle_load_balancers( |
Collaborator
There was a problem hiding this comment.
have you ran one full real end to end test just to make sure this works fine ?
Collaborator
Author
There was a problem hiding this comment.
yes, it works fine but returns 0 findings though as its freshly created LB
javvaji-devops
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.