This repository was archived by the owner on May 6, 2020. It is now read-only.
travis: Add go 1.8 in the test matrix #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Note that one test fails on go tip. It doesn't on neither 1.7 nor 1.8, so I guess something in wrong in go master and will be eventually resolved. |
added 2 commits
February 23, 2017 18:00
When we've already failed the comparison for a previous fd, nothing should be able to make us return true. Unfortunately, we were overriding unconditionally the equal boolean with no regard of the past. This was found testing the proxy on go tip (what will become 1.9), the runtime has changed and exposed that bug. Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
dlespiau
force-pushed
the
20170223-ci-go-1.8
branch
from
65d05a3 to
5b2511f
Compare
Contributor
Author
|
Argh, no! go tip does expose a real bug in the fd leak detector. I fixed the bug in PR #16 |
Contributor
Author
|
All travis tests are green, and it's really all that matters for this PR. Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Damien Lespiau damien.lespiau@intel.com