Skip to content
This repository was archived by the owner on May 6, 2020. It is now read-only.

Conversation

@grahamwhaley
Copy link
Contributor

The CONTRIBUTING file did not have details of our Fixes
requirements for commits. Add some.

Fixes: #321

Signed-off-by: Graham Whaley graham.whaley@intel.com

@grahamwhaley grahamwhaley requested review from iphutch and sboeuf July 13, 2017 10:33
Copy link

@iphutch iphutch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@devimc
Copy link

devimc commented Jul 14, 2017

lgtm

Approved with PullApprove Approved with PullApprove

The CONTRIBUTING file did not have details of our Fixes
requirements for commits. Add some.

Fixes: clearcontainers#321

Signed-off-by: Graham Whaley <graham.whaley@intel.com>
@grahamwhaley grahamwhaley force-pushed the 20170713_CONTRIB_Fixme branch from ebbb482 to 5a97126 Compare July 15, 2017 13:31
@grahamwhaley
Copy link
Contributor Author

Hit the Travis issue. rebased and re-pushed...

@coveralls
Copy link

coveralls commented Jul 15, 2017

Coverage Status

Coverage remained the same at 52.602% when pulling 5a97126 on grahamwhaley:20170713_CONTRIB_Fixme into 8f92b5c on clearcontainers:master.

@devimc devimc merged commit 68171dd into clearcontainers:master Jul 17, 2017
mcastelino pushed a commit to mcastelino/runtime that referenced this pull request Dec 6, 2018
Add brief entries to the README for the following:

- Limitations
- Contact details
- Further information

Fixes clearcontainers#322.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants