Skip to content
This repository was archived by the owner on Aug 7, 2025. It is now read-only.

Conversation

@phmccarty
Copy link
Contributor

  • Support new Github endpoint for autogenerated tarballs (/refs/tags/...).
  • Strip one-letter prefixes from versions in Gitlab URLs, if present.
  • Update tests

phmccarty added 2 commits June 1, 2021 15:51
The Github API endpoint for generating tarballs from tags recently changed, so
teach autospec about the new URL format.

Also add a new packageurl for testing to confirm correct operation of the
regexp that matches the new format.

Signed-off-by: Patrick McCarty <patrick.mccarty@intel.com>
Strip the optional leading character matching "[vVrR]" from a version extracted
from a Gitlab URL.

Update a packageurl test case to accommodate.

Signed-off-by: Patrick McCarty <patrick.mccarty@intel.com>
@phmccarty phmccarty requested a review from mdhorn June 1, 2021 22:54
@phmccarty
Copy link
Contributor Author

For the record, unit tests are failing because apparently /usr/bin/coverage is no longer present in the python-extras bundle... But I confirmed the tests are passing on an older install.

phmccarty added 2 commits June 1, 2021 16:08
Signed-off-by: Patrick McCarty <patrick.mccarty@intel.com>
The `python-extras` bundle dropped the `coverage` command recently, so until
that problem is resolved, run unittests without the coverage analysis.

Signed-off-by: Patrick McCarty <patrick.mccarty@intel.com>
@phmccarty phmccarty merged commit c90aada into clearlinux:master Jun 1, 2021
@phmccarty phmccarty deleted the tarball-patterns branch June 1, 2021 23:16
Copy link
Contributor

@mdhorn mdhorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants