Skip to content
This repository was archived by the owner on Aug 7, 2025. It is now read-only.

Vagrant Libvirt Instructions update#189

Merged
jascott1 merged 3 commits intoclearlinux:masterfrom
ahsan518:doc
Oct 8, 2019
Merged

Vagrant Libvirt Instructions update#189
jascott1 merged 3 commits intoclearlinux:masterfrom
ahsan518:doc

Conversation

@ahsan518
Copy link
Copy Markdown
Contributor

@ahsan518 ahsan518 commented Sep 23, 2019 •
edited
Loading

This patch adds the users to the default group so we dont
have to use sudo to start the vagrant, as using sudo is not
the most optimal route for gems to be properly configured.

Signed-off: Syed Ahsan syed.ahsan.shamim.zaidi@intel.com

@ahsan518
Vagrant Libvirt Instructions update
3c8c53b 
This patch adds the users to the default group so we dont
have to use sudo to start the vagrant, as using sudo is not
the most optimal route for gems to be properly configured.

Signed-off: Syed Ahsan<ahsanmohsin04@yahoo.com>
@AntonioMeireles
Copy link
Copy Markdown
Contributor

AntonioMeireles commented Sep 23, 2019

humm... (hi all!)

FWIW I already got that long ago covered by https://github.com/AntonioMeireles/ClearLinux-packer/blob/master/extras/clearlinux/setup/libvirtd.sh#L15-L17

at sight it's just the sudo calls which are redundant and could be dropped

All the best,

António

@NitinAtIntel
Copy link
Copy Markdown
Contributor

NitinAtIntel commented Sep 23, 2019

Per @AntonioMeireles , here's the PR AntonioMeireles/ClearLinux-packer#20.
It pertains to a script used by instructions we've leveraged to run Vagrant/Libvirt on Clear Linux. If we're not using that script for other host OS' then we may still need to ensure the user is added to the group, so that is one thing to check.
We can leave the removal of sudo I believe as is.

@ahsan518
Copy link
Copy Markdown
Contributor Author

ahsan518 commented Sep 23, 2019

Done

@knangia
Copy link
Copy Markdown
Contributor

knangia commented Sep 23, 2019 •
edited
Loading

Syed, we can still add the user in there and remove the sudo, since these instructions updated by you are for ubuntu, and not clear OS.
The PR referenced above is for having vagrant setup instructions on Clear OS, and we have used https://github.com/AntonioMeireles/ClearLinux-packer/blob/master/extras/clearlinux/setup/libvirtd.sh#L15-L17 there and removed sudo in https://github.com/clearlinux/cloud-native-setup/blob/master/clr-k8s-examples/vagrant.md#install-vagrant-on-clear-linux .

ahsan518
ahsan518 commented Sep 24, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@ahsan518 ahsan518 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

knangia
knangia approved these changes Sep 25, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@knangia knangia left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vagrant instructions for Ubuntu OS lgtm! Correct your Signed-off message

@jascott1 jascott1 merged commit ebff530 into clearlinux:master Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@NitinAtIntel NitinAtIntel NitinAtIntel approved these changes

@knangia knangia knangia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ahsan518 @AntonioMeireles @NitinAtIntel @knangia @jascott1