This repository was archived by the owner on Aug 7, 2025. It is now read-only.
Using consistent ENV variable for RUNNER#273
Merged
CraigSterrett merged 1 commit intoclearlinux:masterfrom Nov 20, 2019
Merged
Conversation
CraigSterrett
suggested changes
Nov 20, 2019
Contributor
There was a problem hiding this comment.
Testing failed these conditions
Neither RUNNER or CLRK8S_RUNNER set
./setup_system.sh
./setup_system.sh: line 14: CLRK8S_RUNNER: unbound variable
export RUNNER=containerd
./setup_system.sh
./setup_system.sh: line 14: CLRK8S_RUNNER: unbound variable
Did not test past this
Earlier there was confusion between CLRK8S_RUNNER and RUNNER in setup_system.sh and create_stack.sh script, this patch fixes this and now the variable can either be RUNNER/CLRK8S_RUNNER. Signed-off: syed.ahsan.shamim.zaidi@intel.com
CraigSterrett
approved these changes
Nov 20, 2019
Contributor
CraigSterrett
left a comment
CraigSterrett
left a comment
There was a problem hiding this comment.
Works as expected, tested with no environment variable set, and then both with CLRK8S_RUNNER and then with just RUNNER.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Earlier there was confusion between CLRK8S_RUNNER and RUNNER in
setup_system.sh and create_stack.sh script, this patch fixes this
and now the variable can either be RUNNER/CLRK8S_RUNNER.
Signed-off: syed.ahsan.shamim.zaidi@intel.com
#272