Skip to content

Bump mkdirp from 0.5.6 to 3.0.1 #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JamieMagee merged 2 commits into from
Jan 26, 2026
Merged

Bump mkdirp from 0.5.6 to 3.0.1 #682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
864ec3a
Bump mkdirp from 0.5.6 to 3.0.1
dependabot[bot] Jan 26, 2026
784fda8
fix: update mkdirp usage to match v3 API
JamieMagee Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ghcrawler/providers/storage/file.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

const fs = require('fs')
const path = require('path')
const mkdirp = require('mkdirp')
const { mkdirpSync } = require('mkdirp')

// TODO finish the implementation of the relevant methods

Expand All @@ -22,7 +22,7 @@ class FileStore {
// const type = document._metadata.type
const urn = document._metadata.links.self.href
const filePath = this._getPath(urn)
mkdirp.sync(path.dirname(filePath))
mkdirpSync(path.dirname(filePath))
return new Promise((resolve, reject) =>
fs.writeFile(filePath, JSON.stringify(document, null, 2), error => (error ? reject(error) : resolve(document)))
)
Expand Down
30 changes: 24 additions & 6 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
"lodash": "^4.17.23",
"luxon": "^3.7.2",
"memory-cache": "^0.2.0",
"mkdirp": "^0.5.1",
"mkdirp": "^3.0.1",
"morgan": "^1.10.1",
"node-html-parser": "^5.3.3",
"node-uuid": "^1.4.8",
Expand Down
4 changes: 2 additions & 2 deletions providers/fetch/nugetFetch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
const AbstractFetch = require('./abstractFetch')
const { trimStart, clone, get } = require('lodash')
const fs = require('fs')
const mkdirp = require('mkdirp')
const { mkdirp } = require('mkdirp')
const path = require('path')
const { promisify } = require('util')
const requestRetry = require('requestretry').defaults({ maxAttempts: 3, fullResponse: true })
Expand Down Expand Up @@ -145,7 +145,7 @@ class NuGetFetch extends AbstractFetch {
async _downloadLicense({ dirName, licenseUrl }) {
if (licenseUrl.toLowerCase().includes('license_url_here_or_delete_this_line')) return
const downloadedLicenseDirName = path.join(dirName, 'clearlydefined', 'downloaded')
await promisify(mkdirp)(downloadedLicenseDirName)
await mkdirp(downloadedLicenseDirName)
const { body, statusCode } = await requestRetry.get(licenseUrl)
if (statusCode !== 200) return
await promisify(fs.writeFile)(path.join(downloadedLicenseDirName, 'LICENSE'), body)
Expand Down