Update Dockerfile entrypoint to use node directly#1384
Merged
qtomlinson merged 1 commit intoclearlydefined:masterfrom Dec 18, 2025
Merged
Update Dockerfile entrypoint to use node directly#1384qtomlinson merged 1 commit intoclearlydefined:masterfrom
qtomlinson merged 1 commit intoclearlydefined:masterfrom
Conversation
ryanbrandenburg
approved these changes
Dec 17, 2025
Contributor
ryanbrandenburg
left a comment
There was a problem hiding this comment.
This looks like a good near-term fix, though I wonder what the long-term objects being retained are.
Collaborator
Author
|
@ryanbrandenburg Thank you for the feedback. This PR provides a short‑term measure to get the service running, and it also introduces two improvements:
|
jeffmendoza
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR improves Docker container behavior by replacing the npm-based entrypoint with direct Node.js execution, enabling proper signal handling and graceful container shutdown.
Background:
the server fails to start with the following error:
The issue is likely caused by the memory allocation setting: the process is requesting 8GB, which exceeds the 7GB provisioned on our dev App Service Plan. This is a known issue tracked at #1256.
Key Changes: