Rename upgrade/ provider to recompute/ and align terminology#1568
Merged
qtomlinson merged 7 commits intoMay 1, 2026
Conversation
…PUTE_*, update providers/index.ts key and interfaces
The class processes compute queue messages, not upgrade queue messages. Rename the class and update log messages to use 'recompute' terminology, keeping _upgradePolicy naming which correctly refers to the upgrade policy used as a guard within the compute path.
Rename upgradeAzureQueueConfig/upgradeMemoryQueueConfig import aliases to recomputeAzureQueueConfig/recomputeMemoryQueueConfig in providers/index.ts — these configs provide both upgrade and compute queue factories, so the upgrade-only prefix was misleading. Change the fallback default in bin/config.ts from 'versionCheck' (deprecated alias) to 'onDemand' so a clean deployment with no env var set uses the current non-deprecated value.
biome 2.4.11 (bumped via Dependabot in 5eaae30) promoted two rules in its recommended ruleset: 1. lint/suspicious/noConfusingVoidType (warning → error): `Promise<void[]>` is now an error in generic position. Fixed by returning `undefined` explicitly from the async lambda so `Promise.all` resolves to `Promise<undefined[]>`. 2. assist/source/organizeImports (implicit): Import order in definitionServiceTest.ts was out of alphabetical order after adding memoryQueueConfig and recomputeHandler imports during the recompute refactor. Fixed by running `biome check --write`.
JamieMagee
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upgrade subsystem handles two distinct concerns — schema upgrade and delayed compute — but its naming (upgrade/, DEFINITION_UPGRADE_PROVIDER, DefinitionUpgrader) implied only the former. This PR renames to better reflect the full scope.
Changes:
redundant Test suffix from test file names
DEFINITION_RECOMPUTE_QUEUE_PROVIDER; old names kept as fallbacks in bin/config.ts for backward compatibility
Not renamed: DEFINITION_UPGRADE_QUEUE_* env vars (QUEUE_NAME, CONNECTION_STRING, DEQUEUE_BATCH_SIZE). These specifically configure the upgrade queue path and remain accurate.
May be easier to review commit by commit