Merged
Conversation
JamieMagee
force-pushed
the
typescript-tests
branch
from
ff9d095 to
f3a176e
Compare
qtomlinson
approved these changes
Apr 7, 2026
- Rename test.js to test.mts with ESM imports - Add type annotations for test data (SpdxExpression, tuples) - Extend tsconfig with @tsconfig/strictest - Add @types/node and npm run typecheck step to CI
JamieMagee
force-pushed
the
typescript-tests
branch
from
f3a176e to
39093f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts test.js to test.mts so the test file is type-checked against the
.d.tsdeclarations from #56. Also wires uptscin CI so type errors don't slip through.require()with ESM imports@tsconfig/strictestand@types/nodeas dev dependenciesnpm run typecheckstep to CI afternpm testNode 24 runs
.mtsdirectly via type stripping, so no build step ortsxneeded.