Bls12 377 gadgets for Groth16#19
Merged
Merged
Conversation
dtebbs
force-pushed
the
bls12-377-gadgets-groth16
branch
4 times, most recently
from
67d0914 to
20a777e
Compare
dtebbs
force-pushed
the
bls12-377-gadgets-final-exp
branch
3 times, most recently
from
3734567 to
66074c7
Compare
dtebbs
force-pushed
the
bls12-377-gadgets-groth16
branch
3 times, most recently
from
da8fb60 to
afca9c9
Compare
dtebbs
commented
Jul 22, 2020
Contributor
Author
dtebbs
left a comment
dtebbs
left a comment
There was a problem hiding this comment.
Reminder to address consistency of #ifndef, #ifdef and #if forms.
dtebbs
force-pushed
the
bls12-377-gadgets-final-exp
branch
3 times, most recently
from
eedba35 to
e35f386
Compare
dtebbs
force-pushed
the
bls12-377-gadgets-groth16
branch
from
e9fab87 to
1d99b78
Compare
dtebbs
force-pushed
the
bls12-377-gadgets-final-exp
branch
2 times, most recently
from
108bef3 to
73c3b11
Compare
dtebbs
force-pushed
the
bls12-377-gadgets-groth16
branch
from
1d99b78 to
42c7f53
Compare
dtebbs
changed the title
| , A(pb, FMT(annotation_prefix, " A")) | ||
| , check_A( | ||
| pb, in_R.X, in_R.Y, A * FqT(2), FMT(annotation_prefix, " check_A")) | ||
| , _A(pb, |
Contributor
There was a problem hiding this comment.
Let's be consistent on how we build these gadgets here. I most parts of the code base, smart ptrs are used and passed as args before being reset/new'ed in the parent gadget's constructor. This contrasts with the existing code.
To be clear, I am not suggesting to do this as part of this PR, but rather to keep this in mind as further improvement going forward.
| // B = Ry^2 | ||
| , B(pb, FMT(annotation_prefix, " B")) | ||
| , check_B(pb, in_R.Y, B, FMT(annotation_prefix, " check_B")) | ||
| , _B(pb, |
Contributor
There was a problem hiding this comment.
Another place where #20 would apply.
_B->compute_B(same for the annotation)Ry^2(the output wire annotation) ->B
Same applies for the other gadgets in this file
Contributor
Author
There was a problem hiding this comment.
This should be covered in a later change.
dtebbs
force-pushed
the
bls12-377-gadgets-groth16
branch
from
993a66a to
3ceb134
Compare
dtebbs
changed the base branch from
bls12-377-gadgets-final-exp
to
bls12-377-gadgets
dtebbs
force-pushed
the
bls12-377-gadgets-groth16
branch
from
934a45a to
3e670e3
Compare
dtebbs
changed the title
…e towards making it fully generic)
…ct form. full pairing test.
…ementation and tests
…or better diagnostics
…ions only. Types describing snark verification gadgets. Parameterize all code by snark and add test configs.
dtebbs
force-pushed
the
bls12-377-gadgets-groth16
branch
from
3e670e3 to
616488b
Compare
AntoineRondelet
added a commit
that referenced
this pull request
Jul 28, 2020
Update zeth (depends on #19)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.