CORE-1738: wireless_watcher dies #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
If you're committed to the field-by-field approach, please us dict.get rather than all these try blocks swallowing errors. But a better approach (IMO) would be to detect upfront when not connected at all and just never hit this code path. Then again, my recollection about all this is that the format of iwconfig output varies from between different wireless cards/drivers, so maybe it's better to just be robust upfront and not try to play whack-a-mole with it. |
Author
|
Added the check for wifi connection and to bypass the parsing if it's not connected. Also, I left the field-by-field checks in to account for the variations in the iwconfig output. |
Contributor
|
LGTM. |
mikepurvis
added a commit
that referenced
this pull request
Aug 6, 2015
CORE-1738: wireless_watcher dies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the wifi is not connected to any network, the wireless_watcher node crashes as it's not able to parse the 'Bit Rate' and other fields. I just added a try block for each field, although I'm not sure if this is the best way to do this..