You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Before the test, iterate CTheScripts::pIdleScripts and write some value to all inactive scripts ScmFunction Id and IsCustom
Start new script
Validate new struct is clean
Iterate scripts again and reset values.
Despite of the crash the fact that bIsCustom could be randomly set was disaster.
I don't think it was possible unless the script code itself did that. CLEO only sets it for custom scripts and they are never part of idle pool for game to pick up
Despite of the crash the fact that bIsCustom could be randomly set was disaster.
I don't think it was possible unless the script code itself did that. CLEO only sets it for custom scripts and they are never part of idle pool for game to pick up
Hm right. ScmFunction field was actually one creating the problems.
So far I have no crashes even with more strict ScmFunction storage from another branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hooked CRunning::ScriptInit so ScmFunction and bIsCustom are properly initialized.