feat: Add support for excluding routes in middleware#19
Merged
Conversation
agis
changed the title
This patch adds a new configuration option, with which one is able to declare routes that the middleware should not execute on. This is done by either specifying an exact match, e.g. "/foo" or a prefix match, e.g. "/foo/*". The latter syntax is implemented using a naive linear search, but since most people will use only a handful of those entries, my instinct tells me this is fine. If we want to optimize this later on, we could use a prefix tree or something similar.
agis
force-pushed
the
excluded-routes
branch
from
910a92e to
72ade5f
Compare
SokratisVidros
approved these changes
Sep 20, 2022
gkats
approved these changes
Sep 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds a new configuration option, with which one is able to declare routes that the middleware should not execute on.
This is done by either specifying an exact match, e.g. "/foo" or a prefix match, e.g. "/foo/*".
The latter syntax is implemented using a naive linear search, but since most people will use only a handful of those entries, this should be fine. (If we want to optimize this later on, we could use a prefix tree or something similar.)