fix(update): Do not hang if package manager is not present#243
Conversation
I don't have `yarn` installed, and this produced a hang on `clerk update`. The cause of the hang was that it was sitting waiting for user confirmation to download `yarn`, but never surfaced this to the user. Instead, ignore `stdin`, explicitly do not use corepack download prompts, and add a timeout.
🦋 Changeset detectedLatest commit: 8ce4615 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
!snapshot |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughA new Changesets metadata file documents a clerk patch update addressing package manager probe hangs. The installer.ts file is refactored to consolidate npm/pnpm/yarn global directory discovery into a shared Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Snapshot publishednpm install -g clerk@1.1.1-snapshot.8ce4615
|
I don't have
yarninstalled, and this produced a hang onclerk update. The cause of the hang was that it was sitting waiting for user confirmation to downloadyarn, but never surfaced this to the user. Instead, ignorestdin, explicitly do not use corepack download prompts, and add a timeout.