COR-439 fix(clerk-js): Add base64 string support for organization logo#1309
Merged
COR-439 fix(clerk-js): Add base64 string support for organization logo#1309
Conversation
🦋 Changeset detectedLatest commit: c42b4ac The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
raptisj
changed the title
![jit-ci[bot]](https://avatars.githubusercontent.com/in/142441?s=60&v=4){kind=small}
dimkl
approved these changes
Jun 7, 2023
Contributor
dimkl
left a comment
dimkl
left a comment
There was a problem hiding this comment.
❓ Could you please add a test?
gkats
reviewed
Jun 7, 2023
raptisj
force-pushed
the
organization_logo_format
branch
2 times, most recently
from
b335dfb to
35ddc42
Compare
panteliselef
approved these changes
Jun 7, 2023
anagstef
approved these changes
Jun 8, 2023
raptisj
force-pushed
the
organization_logo_format
branch
3 times, most recently
from
8bd85a3 to
523592e
Compare
fix(clerk-js): Add base64 string support for organization logo fix(clerk-js): Add base64 string support for organization logo
raptisj
force-pushed
the
organization_logo_format
branch
from
523592e to
c42b4ac
Compare
panteliselef
approved these changes
Jun 12, 2023
Contributor
panteliselef
left a comment
panteliselef
left a comment
There was a problem hiding this comment.
It is good and up-to-date 💯
Merged
Collaborator
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/choreDescription
npm testruns as expected.npm run buildruns as expected.Add base64 string support in
Organization.setLogo