fix(clerk-js,types): Disable fields for SAML only if there is an acti…#1326
Merged
yourtallness merged 1 commit intomainfrom Jun 16, 2023
Conversation
yourtallness
requested review from
SokratisVidros and
nikosdouvlis
as code owners
🦋 Changeset detectedLatest commit: f7e739a The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![jit-ci[bot]](https://avatars.githubusercontent.com/in/142441?s=60&v=4){kind=small}
yourtallness
force-pushed
the
mark/auth-580-convey-indication-whether-saml-connection-is-enabled-in-the
branch
from
e3fc2e6 to
cada6a4
Compare
yourtallness
requested review from
anagstef,
chanioxaris,
desiprisg,
dimkl and
panteliselef
anagstef
approved these changes
Jun 9, 2023
nikosdouvlis
approved these changes
Jun 14, 2023
yourtallness
force-pushed
the
mark/auth-580-convey-indication-whether-saml-connection-is-enabled-in-the
branch
3 times, most recently
from
0f8888e to
fc56574
Compare
yourtallness
force-pushed
the
mark/auth-580-convey-indication-whether-saml-connection-is-enabled-in-the
branch
from
fc56574 to
f7e739a
Compare
yourtallness
deleted the
mark/auth-580-convey-indication-whether-saml-connection-is-enabled-in-the
branch
Merged
Collaborator
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ve connection
Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/choreDescription
npm testruns as expected.npm run buildruns as expected.Note:
Depends on the API to expose the
saml_account.activefield first.Not to be merged before this is available.
Password, first name & last name will only be disabled if there are active SAML connections (not just any connections).