Skip to content

feat(clerk-js,types): Introduce logoLinkUrl prop in appearance#1449

Merged
nikospapcom merged 1 commit intomainfrom
papageorgiou/dsh-360-add-after-logo-click-to-clerk-components
Aug 4, 2023
Merged

feat(clerk-js,types): Introduce logoLinkUrl prop in appearance#1449
nikospapcom merged 1 commit intomainfrom
papageorgiou/dsh-360-add-after-logo-click-to-clerk-components

Conversation

@nikospapcom
Copy link
Copy Markdown
Contributor

@nikospapcom nikospapcom commented Jul 4, 2023

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/fastify
  • @clerk/chrome-extension
  • gatsby-plugin-clerk
  • build/tooling/chore

Description

  • npm test runs as expected.
  • npm run build runs as expected.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jul 4, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 2d8e4a0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@clerk/clerk-js Minor
@clerk/types Minor
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/backend Patch
@clerk/fastify Patch
gatsby-plugin-clerk Patch
@clerk/localizations Patch
@clerk/nextjs Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nikospapcom
Copy link
Copy Markdown
Contributor Author

nikospapcom commented Jul 4, 2023

!snapshot

jit-ci[bot]
jit-ci Bot reviewed Jul 4, 2023
View reviewed changes
Copy link
Copy Markdown

@jit-ci jit-ci Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Great news! Jit hasn't found any security issues in your PR. Good Job! 🏆

@clerk-cookie
Copy link
Copy Markdown
Collaborator

clerk-cookie commented Jul 4, 2023

Hey @nikospapcom - the snapshot version command generated the following package versions:

Package Version
@clerk/backend 0.23.8-snapshot.ab1d310
@clerk/chrome-extension 0.3.20-snapshot.ab1d310
@clerk/clerk-js 4.52.0-snapshot.ab1d310
eslint-config-custom 0.3.0
@clerk/clerk-expo 0.18.11-snapshot.ab1d310
@clerk/fastify 0.5.7-snapshot.ab1d310
gatsby-plugin-clerk 4.3.20-snapshot.ab1d310
@clerk/localizations 1.22.1-snapshot.ab1d310
@clerk/nextjs 4.21.14-snapshot.ab1d310
@clerk/clerk-react 4.21.2-snapshot.ab1d310
@clerk/remix 2.6.17-snapshot.ab1d310
@clerk/clerk-sdk-node 4.10.15-snapshot.ab1d310
@clerk/shared 0.19.1
@clerk/themes 1.7.5
@clerk/types 3.47.0-snapshot.ab1d310

Tip: use the snippet copy button below to quickly install the required packages.

# @clerk/backend
npm i @clerk/backend@0.23.8-snapshot.ab1d310
# @clerk/chrome-extension
npm i @clerk/chrome-extension@0.3.20-snapshot.ab1d310
# @clerk/clerk-js
npm i @clerk/clerk-js@4.52.0-snapshot.ab1d310
# eslint-config-custom
npm i eslint-config-custom@0.3.0
# @clerk/clerk-expo
npm i @clerk/clerk-expo@0.18.11-snapshot.ab1d310
# @clerk/fastify
npm i @clerk/fastify@0.5.7-snapshot.ab1d310
# gatsby-plugin-clerk
npm i gatsby-plugin-clerk@4.3.20-snapshot.ab1d310
# @clerk/localizations
npm i @clerk/localizations@1.22.1-snapshot.ab1d310
# @clerk/nextjs
npm i @clerk/nextjs@4.21.14-snapshot.ab1d310
# @clerk/clerk-react
npm i @clerk/clerk-react@4.21.2-snapshot.ab1d310
# @clerk/remix
npm i @clerk/remix@2.6.17-snapshot.ab1d310
# @clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@4.10.15-snapshot.ab1d310
# @clerk/shared
npm i @clerk/shared@0.19.1
# @clerk/themes
npm i @clerk/themes@1.7.5
# @clerk/types
npm i @clerk/types@3.47.0-snapshot.ab1d310

@nikospapcom nikospapcom force-pushed the papageorgiou/dsh-360-add-after-logo-click-to-clerk-components branch from ab1d310 to b344fb4 Compare July 4, 2023 08:51
@nikospapcom nikospapcom marked this pull request as ready for review July 4, 2023 08:51
desiprisg
desiprisg reviewed Jul 4, 2023
View reviewed changes
Comment thread packages/clerk-js/src/ui/elements/ApplicationLogo.tsx Outdated
nikosdouvlis
nikosdouvlis reviewed Jul 4, 2023
View reviewed changes
Comment thread .changeset/wise-badgers-cover.md Outdated
@nikospapcom nikospapcom force-pushed the papageorgiou/dsh-360-add-after-logo-click-to-clerk-components branch from a53b20f to 386c473 Compare July 4, 2023 11:52
nikosdouvlis
nikosdouvlis reviewed Jul 5, 2023
View reviewed changes
Comment thread .changeset/hungry-radios-protect.md Outdated
@nikospapcom nikospapcom marked this pull request as draft July 5, 2023 08:53
@nikospapcom nikospapcom force-pushed the papageorgiou/dsh-360-add-after-logo-click-to-clerk-components branch from f290e1c to 39ca1b1 Compare July 5, 2023 08:56
@nikospapcom nikospapcom force-pushed the papageorgiou/dsh-360-add-after-logo-click-to-clerk-components branch 4 times, most recently from 6395586 to 27b5e0a Compare July 6, 2023 14:17
@nikospapcom nikospapcom force-pushed the papageorgiou/dsh-360-add-after-logo-click-to-clerk-components branch from 87ea379 to fda23d3 Compare July 13, 2023 06:21
@nikospapcom nikospapcom force-pushed the papageorgiou/dsh-360-add-after-logo-click-to-clerk-components branch 8 times, most recently from a7a0d6a to 32acd93 Compare July 21, 2023 09:50
@nikospapcom nikospapcom force-pushed the papageorgiou/dsh-360-add-after-logo-click-to-clerk-components branch 5 times, most recently from be078b1 to c51e290 Compare July 31, 2023 06:30
@nikospapcom nikospapcom force-pushed the papageorgiou/dsh-360-add-after-logo-click-to-clerk-components branch 4 times, most recently from f941720 to 8b4eb49 Compare August 2, 2023 09:41
@nikospapcom
Copy link
Copy Markdown
Contributor Author

nikospapcom commented Aug 2, 2023

!snapshot

@clerk-cookie
Copy link
Copy Markdown
Collaborator

clerk-cookie commented Aug 2, 2023

Hey @nikospapcom - the snapshot version command generated the following package versions:

Package Version
@clerk/backend 0.27.0-snapshot.8b4eb49
@clerk/chrome-extension 0.3.26-snapshot.8b4eb49
@clerk/clerk-js 4.55.0-snapshot.8b4eb49
eslint-config-custom 0.3.0
@clerk/clerk-expo 0.18.17-snapshot.8b4eb49
@clerk/fastify 0.6.3-snapshot.8b4eb49
gatsby-plugin-clerk 4.4.4-snapshot.8b4eb49
@clerk/localizations 1.24.1-snapshot.8b4eb49
@clerk/nextjs 4.23.2-snapshot.8b4eb49
@clerk/clerk-react 4.23.2-snapshot.8b4eb49
@clerk/remix 2.9.1-snapshot.8b4eb49
@clerk/clerk-sdk-node 4.12.2-snapshot.8b4eb49
@clerk/shared 0.21.0-snapshot.8b4eb49
@clerk/themes 1.7.5
@clerk/types 3.49.0-snapshot.8b4eb49

Tip: use the snippet copy button below to quickly install the required packages.

# @clerk/backend
npm i @clerk/backend@0.27.0-snapshot.8b4eb49
# @clerk/chrome-extension
npm i @clerk/chrome-extension@0.3.26-snapshot.8b4eb49
# @clerk/clerk-js
npm i @clerk/clerk-js@4.55.0-snapshot.8b4eb49
# eslint-config-custom
npm i eslint-config-custom@0.3.0
# @clerk/clerk-expo
npm i @clerk/clerk-expo@0.18.17-snapshot.8b4eb49
# @clerk/fastify
npm i @clerk/fastify@0.6.3-snapshot.8b4eb49
# gatsby-plugin-clerk
npm i gatsby-plugin-clerk@4.4.4-snapshot.8b4eb49
# @clerk/localizations
npm i @clerk/localizations@1.24.1-snapshot.8b4eb49
# @clerk/nextjs
npm i @clerk/nextjs@4.23.2-snapshot.8b4eb49
# @clerk/clerk-react
npm i @clerk/clerk-react@4.23.2-snapshot.8b4eb49
# @clerk/remix
npm i @clerk/remix@2.9.1-snapshot.8b4eb49
# @clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@4.12.2-snapshot.8b4eb49
# @clerk/shared
npm i @clerk/shared@0.21.0-snapshot.8b4eb49
# @clerk/themes
npm i @clerk/themes@1.7.5
# @clerk/types
npm i @clerk/types@3.49.0-snapshot.8b4eb49

@nikospapcom nikospapcom force-pushed the papageorgiou/dsh-360-add-after-logo-click-to-clerk-components branch from 8b4eb49 to 2d8e4a0 Compare August 4, 2023 08:51
@nikospapcom nikospapcom merged commit 89bc5de into main Aug 4, 2023
@nikospapcom nikospapcom deleted the papageorgiou/dsh-360-add-after-logo-click-to-clerk-components branch August 4, 2023 08:57
@clerk-cookie clerk-cookie mentioned this pull request Aug 4, 2023
Merged
@clerk-cookie
Copy link
Copy Markdown
Collaborator

clerk-cookie commented Aug 4, 2024

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@clerk clerk locked as resolved and limited conversation to collaborators Aug 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nikosdouvlis nikosdouvlis nikosdouvlis approved these changes

@dimkl dimkl Awaiting requested review from dimkl

@anagstef anagstef Awaiting requested review from anagstef

@panteliselef panteliselef Awaiting requested review from panteliselef

@raptisj raptisj Awaiting requested review from raptisj

+4 more reviewers

@yourtallness yourtallness yourtallness approved these changes

@desiprisg desiprisg desiprisg left review comments

@jit-ci jit-ci[bot] jit-ci[bot] left review comments

@SokratisVidros SokratisVidros SokratisVidros approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

clerk-js types

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nikospapcom @clerk-cookie @SokratisVidros @nikosdouvlis @yourtallness @desiprisg