feat(clerk-js): Notify admins for pending requests in OrganizationSwitcher#1670
Merged
panteliselef merged 5 commits intomainfrom Sep 1, 2023
Merged
feat(clerk-js): Notify admins for pending requests in OrganizationSwitcher#1670panteliselef merged 5 commits intomainfrom
panteliselef merged 5 commits intomainfrom
Conversation
panteliselef
requested review from
SokratisVidros and
nikosdouvlis
as code owners
🦋 Changeset detectedLatest commit: de2c146 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
panteliselef
changed the title
chanioxaris
approved these changes
Sep 1, 2023
Member
chanioxaris
left a comment
chanioxaris
left a comment
There was a problem hiding this comment.
Great job, animations looks smooth to me 💯
| const NotificationCountBadgeManageButton = () => { | ||
| const { membership } = useCoreOrganization(); | ||
| const { organizationSettings } = useEnvironment(); | ||
| const isAdmin = membership?.role === 'admin'; |
Member
There was a problem hiding this comment.
Irrelevant to this PR, but that's a nice candidate to introduce a HasRole() method on the MembershipResource
…mponent This allows us to position a notification badge by the action.
…tcher and Members page
panteliselef
force-pushed
the
ORG-188
branch
from
ab6afb1 to
de2c146
Compare
Merged
Collaborator
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/choreDescription
npm testruns as expected.npm run buildruns as expected.This PR is an improvement for the notification badge in OrganizationSwitcher
Screen.Recording.2023-09-01.at.12.21.06.PM.mov