Skip to content

fix(clerk-js): Missing or broken breadcrumbs #1722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
panteliselef merged 2 commits into from
Sep 14, 2023
Merged

fix(clerk-js): Missing or broken breadcrumbs #1722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34b3074
fix(clerk-js): Missing or broken breadcrumbs
panteliselef Sep 14, 2023
afb4926
chore(clerk-js): Add changeset
panteliselef Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/silly-numbers-sell.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---

Fix bug with missing or incorrect breadcrumbs in Organization and User profiles
1 change: 1 addition & 0 deletions packages/clerk-js/src/ui/components/OrganizationProfile/ActionConfirmationPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ const ActionConfirmationPage = withCardStateProvider((props: ActionConfirmationP
<Wizard {...wizard.props}>
<ContentPage
headerTitle={title}
breadcrumbTitle={localizationKeys('organizationProfile.profilePage.dangerSection.title')}
Breadcrumbs={OrganizationProfileBreadcrumbs}
>
<Form.Root onSubmit={handleSubmit}>
Expand Down
1 change: 1 addition & 0 deletions packages/clerk-js/src/ui/components/OrganizationProfile/OrganizationProfileNavbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ const pageToRootNavbarRouteMap = {
domain: organizationProfileRoutes.find(r => r.id === 'settings'),
profile: organizationProfileRoutes.find(r => r.id === 'settings'),
leave: organizationProfileRoutes.find(r => r.id === 'settings'),
delete: organizationProfileRoutes.find(r => r.id === 'settings'),
};

export const OrganizationProfileBreadcrumbs = (props: Pick<PropsOfComponent<typeof Breadcrumbs>, 'title'>) => {
Expand Down
5 changes: 4 additions & 1 deletion packages/clerk-js/src/ui/components/UserProfile/ConnectedAccountsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,10 @@ const AddConnectedAccount = () => {
};

return (
<ContentPage headerTitle={localizationKeys('userProfile.connectedAccountPage.title')}>
<ContentPage
headerTitle={localizationKeys('userProfile.connectedAccountPage.title')}
Breadcrumbs={UserProfileBreadcrumbs}
>
<Text
localizationKey={
unconnectedStrategies.length
Expand Down
10 changes: 8 additions & 2 deletions packages/clerk-js/src/ui/components/UserProfile/EmailPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,10 @@ export const EmailPage = withCardStateProvider(() => {

return (
<Wizard {...wizard.props}>
<ContentPage headerTitle={title}>
<ContentPage
headerTitle={title}
Breadcrumbs={UserProfileBreadcrumbs}
>
<Form.Root onSubmit={addEmail}>
<Form.ControlRow elementId={emailField.id}>
<Form.Control
Expand All @@ -71,7 +74,10 @@ export const EmailPage = withCardStateProvider(() => {
</Form.Root>
</ContentPage>

<ContentPage headerTitle={title}>
<ContentPage
headerTitle={title}
Breadcrumbs={UserProfileBreadcrumbs}
>
{preferMagicLinks ? (
<VerifyWithLink
nextStep={wizard.nextStep}
Expand Down