fix(clerk-js): Correctly display all badges email/phone#1749
Merged
panteliselef merged 1 commit intomainfrom Sep 21, 2023
Merged
fix(clerk-js): Correctly display all badges email/phone#1749panteliselef merged 1 commit intomainfrom
panteliselef merged 1 commit intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 4d8882d The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
panteliselef
force-pushed
the
ORG-223
branch
from
96b98be to
a51bb9a
Compare
panteliselef
changed the title
panteliselef
force-pushed
the
ORG-223
branch
3 times, most recently
from
76f17b0 to
d691dce
Compare
panteliselef
force-pushed
the
ORG-223
branch
from
d691dce to
4d8882d
Compare
Merged
octoper
pushed a commit
that referenced
this pull request
Sep 25, 2023
Collaborator
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This bug was introduced when we moved the "unverified" badges from the body of the expandable to the trigger. Previously the "primary" badge always had priority over the "unverified". We decided to display both.
This PR displays both badges when needed.
Before
After
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/chore