chore(clerk-js): Apply deprecation warnings#1779
Conversation
🦋 Changeset detectedLatest commit: af4b7ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
43e7f26 to
6d57a48
Compare
e835be8 to
18537a5
Compare
18537a5 to
4dde358
Compare
|
@nikosdouvlis PTAL
ref: 4dde358 |
|
@dimkl could we skip deprecating nested properties for this PR and resolve it in a followup ? |
…ties The `logoUrl` properties from the snapshots even though they still exist in those classes because of the way the deprecation helper works to mark the property as deprecated. The deprecation helper redefine the property in the class prototype using a getter/setter that shows a warning in getter using the Object.defineProperty(). By redefining a property, that property is not considered class own property any more which causes the jest snapshot and the JSON.stringify() to omit that property. This is a side-effect of the deprecation implementation and not a spec but i think that we are okay to proceed with omitting the properties from snapshots.
7ea445f to
af4b7ba
Compare
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Review it per commit
Deprecation warnings added in
@clerk/clerk-js:Organization.create()using string parameterOrganization.retrieve()limit&offsetClerk.getOrganizationMemberships()svgUrlavatarUrl/logoUrl/faviconUrl/profileImageUrlNotes: We cannot show deprecation warnings in console for deprecated type properties (eg
UserJSON.profile_image_url)TODO:
Relevant PRs:
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/chore