Conversation
🦋 Changeset detectedLatest commit: c077efc The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dimkl
force-pushed
the
fix-shared-nested-props-deprecation
branch
from
67f159e to
ea69ca3
Compare
nikosdouvlis
approved these changes
Oct 2, 2023
Comment on lines
+14
to
+16
| import { BaseResource } from './Base'; | ||
| import { Organization } from './Organization'; | ||
| import { OrganizationPublicUserData } from './OrganizationPublicUserData'; |
Member
There was a problem hiding this comment.
Suggested change
| import { BaseResource } from './Base'; | |
| import { Organization } from './Organization'; | |
| import { OrganizationPublicUserData } from './OrganizationPublicUserData'; | |
| import { BaseResource, Organization, OrganizationPublicUserData } from './internal'; |
|
|
||
| import { unixEpochToDate } from '../../utils/date'; | ||
| import { BaseResource } from './Base'; | ||
| import { OrganizationPublicUserData } from './OrganizationPublicUserData'; |
Member
There was a problem hiding this comment.
Suggested change
| import { OrganizationPublicUserData } from './OrganizationPublicUserData'; | |
| import { OrganizationPublicUserData } from './internal'; |
dimkl
force-pushed
the
fix-shared-nested-props-deprecation
branch
from
ea69ca3 to
5b93b39
Compare
dimkl
force-pushed
the
fix-shared-nested-props-deprecation
branch
from
5b93b39 to
2814252
Compare
dimkl
force-pushed
the
fix-shared-nested-props-deprecation
branch
from
2814252 to
3403ccf
Compare
…ation warning To support the nested property deprecation we introduced a class to handle loading the PublicUserData and added a deprecation warning on that class profileImageUrl property. This changed was introduced based on the example of how the OrganizationMembership loads the Organization data.
dimkl
force-pushed
the
fix-shared-nested-props-deprecation
branch
from
3403ccf to
c077efc
Compare
Merged
Collaborator
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To support the nested property deprecation we introduced a class to handle loading the
PublicUserDataand added a deprecation warning on that classprofileImageUrlproperty. This change was introduced based on the example of how theOrganizationMembershiploads theOrganizationdata.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/chore